Beefy Boxes and Bandwidth Generously Provided by pair Networks
Think about Loose Coupling
 
PerlMonks  

Re^2: splitting file with mutiple output filenames

by GrandFather (Saint)
on Apr 11, 2012 at 09:31 UTC ( [id://964487]=note: print w/replies, xml ) Need Help??


in reply to Re: splitting file with mutiple output filenames
in thread splitting file with mutiple output filenames

Ok, you solved problem, but let's make the post worth while by passing on the usual round of "wisdom". Consider:

#!/usr/bin/perl # chess.plx use warnings; use strict; use utf8; my $filename = "thaikjv-fixed.txt"; open my $fIn, '<', $filename or die "Can't open $filename: $!\n"; binmode ($fIn, ":utf8"); while (defined (my $line = <$fIn>)) { next if $line !~ /^@(...\d\d\d)/; my $outname = "$1.html"; open my $fOut, '>', $outname or die "Can't create $outname: $!\n"; binmode ($fOut, ":utf8"); print $fOut $line; print "hi"; close $fOut; }

Note:

  • use three parameter version of open and lexical file handles
  • show the file name in errors
  • use a while loop instead of a for loop when reading files
  • use early exit to avoid extra levels of indentation
  • avoid using the default variable across multiple lines
True laziness is hard work

Replies are listed 'Best First'.
Re^3: splitting file with mutiple output filenames
by moritz (Cardinal) on Apr 11, 2012 at 09:49 UTC

Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://964487]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others pondering the Monastery: (3)
As of 2024-04-26 07:29 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found