Beefy Boxes and Bandwidth Generously Provided by pair Networks
"be consistent"

Re^2: hash and array mismatch

by TGI (Parson)
on May 10, 2007 at 17:31 UTC ( #614711=note: print w/replies, xml ) Need Help??

in reply to Re: hash and array mismatch
in thread hash and array mismatch

I assume your snippet is intended to go inside the OP's for loop:

foreach my $i ( 0..$#data ) { my %keys = keys %dataPos; # Changed hash name to match hash OP is +building my $hkey = $data[$i]; # Changed data lookup to array to match O +P code. if ((my @found = grep /^$hkey$/, %keys) > 1) { $hkey .= '_'; } $dataPos{$hkey} = $i; print "$data[$i] -- > $i\n"; }

After I tweaked your code to work with the OP's code, there are still problems. You have a unnecessary nested loop that will grow with each pass through the outer loop. Also, if a key shows up three or more times, the last value will overwrite the value stored for the second key.

I've fixed these issues below.

foreach my $i ( 0..$#data ) { my $key = $data[i]; # append '_' until no matching key exists. while ( exists $dataPos{$key} ) { $key .= '_'; } $dataPos{$key} = $i; print "$key -- > $i\n"; }

Even after its been fixed, I still wouldn't use this approach. I'd store repeated values in arrays as other posters have suggested.

TGI says moo

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://614711]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others taking refuge in the Monastery: (3)
As of 2023-09-30 23:39 GMT
Find Nodes?
    Voting Booth?

    No recent polls found