Beefy Boxes and Bandwidth Generously Provided by pair Networks
Clear questions and runnable code
get the best and fastest answer

Re: hash and array mismatch

by TOD (Friar)
on May 08, 2007 at 02:07 UTC ( #614081=note: print w/replies, xml ) Need Help??

in reply to hash and array mismatch

that's fairly easy to answer: the hash keys are identical. you might work around this bug with something like the following:
my %keys = keys %data; my $hkey = $data{$i}; if ((my @found = grep /^$hkey$/, %keys) > 1) { $hkey .= '_'; } $dataPos{$hkey} = $i;
masses are the opiate for religion.

Replies are listed 'Best First'.
Re^2: hash and array mismatch
by TGI (Parson) on May 10, 2007 at 17:31 UTC

    I assume your snippet is intended to go inside the OP's for loop:

    foreach my $i ( 0..$#data ) { my %keys = keys %dataPos; # Changed hash name to match hash OP is +building my $hkey = $data[$i]; # Changed data lookup to array to match O +P code. if ((my @found = grep /^$hkey$/, %keys) > 1) { $hkey .= '_'; } $dataPos{$hkey} = $i; print "$data[$i] -- > $i\n"; }

    After I tweaked your code to work with the OP's code, there are still problems. You have a unnecessary nested loop that will grow with each pass through the outer loop. Also, if a key shows up three or more times, the last value will overwrite the value stored for the second key.

    I've fixed these issues below.

    foreach my $i ( 0..$#data ) { my $key = $data[i]; # append '_' until no matching key exists. while ( exists $dataPos{$key} ) { $key .= '_'; } $dataPos{$key} = $i; print "$key -- > $i\n"; }

    Even after its been fixed, I still wouldn't use this approach. I'd store repeated values in arrays as other posters have suggested.

    TGI says moo

Log In?

What's my password?
Create A New User
Domain Nodelet?
Node Status?
node history
Node Type: note [id://614081]
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others musing on the Monastery: (1)
As of 2023-09-28 18:18 GMT
Find Nodes?
    Voting Booth?

    No recent polls found