In addition to the previously mentioned missing curlies,
-
my($num1,$flag)=shift; takes one value from @_ and assigns to the first of two. $flag never gets a value. You want
my $num1 = shift;
my $flag = shift;
or
my ($num1, $flag) = @_;
-
Then there's the issue that your program always dies. Return the value you find instead of dying. This will also allow you to remove the print from fact, which is appropriate since finding the factorial of a number has nothing to do with I/O.
-
Finally, it's very weird that your factorial function takes two inputs. That's inconsistent with the mathematical function.
Solution:
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
