After a quick skim, it looks pretty good to me, one comment on the SYNOPSIS though.
sub get_widget {
my ($self, $params) = @_;
unless (my_validation_function($params->{product_number})) {
REST_error('404', 'Invalid product_number');
}
my $widget = $widgets[$params->{product_number}];
if (REST_media_type eq 'text/plain') {
return $self->plain_output($widget);
}
return $self->fancy_output($widget);
}
Shouldn't the calls to REST_error and REST_media_type be method calls, and not function calls?
Also, I would suggest wrapping $params in an object as well. You might not need it now, but when you do, it will be a royal pain to go back and change all the legacy code. (give Class::Param a look, it seems to have lots of functionality available if/when you need it)
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|