Hello perlsage, congrats for your first post :)
In addition to the observations Juerd made, I have two more nits to pick:
- Instead of modifying and customizing the module for each service you want to monitor, why not make an object-oriented interface to let people customize their own services? The perlboot and perltoot manpages have some examples.
- "Perlsvc" is quite misleading. My first association was D.J.Bernsteins daemontools package for Unix :). How about naming it something like Win32::Service::Monitor? (that's not a good name yet, but maybe a starter.)
I hope these comments help you to improve your code. Feel free to update this node with improved code or post some questions if you need help with any of the aspects we mentioned.
Have fun!
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
