XP is just a number | |
PerlMonks |
Re^4: Pearls (not really) of Perl programmingby rir (Vicar) |
on Nov 29, 2004 at 18:28 UTC ( [id://410993]=note: print w/replies, xml ) | Need Help?? |
Thanks for the correction.
It was my error to be seduced by the control flow like
use of logical short circuiting to the point of thinking
statements instead of an expression. More succinctly: I
had another braindead moment.
Now that you've drawn my attention to the code again. I say it is that baroque. My initial justification was just for the and 1 stuff which I still don't find so bad. I would still like a or $a cmp $b or a or 0 or die "domain err". It is not readily apparent what is to happen with other/other comparisions. This seems like a significant decision point in the code (by the identifiers) and so a good place for extra clarity. I can imagine myself referring to this snippet to understand how all the subsequent parsing code is recieving data. This may be such a recurring problem in the codebase that it seems unimportant. What does irk is the inconsistent use of short-circuiting, the sub-clauses are unnecessary and so confusing. (I just trusted that aspect the first time around. If I were going to write in that form I'd write something like: Be well.
In Section
Meditations
|
|