Beefy Boxes and Bandwidth Generously Provided by pair Networks
laziness, impatience, and hubris

Re: Answering Machine scripting engine

by mandog (Curate)
on Jul 26, 2004 at 02:46 UTC ( [id://377342] : note . print w/replies, xml ) Need Help??

in reply to Answering Machine scripting engine

A few quick, random and superficial thoughts:

  • IMNSHO, The &init style is somewhat deprecated in favor of init()
  • use Common looks like an private library
  • my %menuHash; look like semiStudlyCaps which is deprecated in In Chapter 24 of The Camel
  • In perl's before 5.8 overiding the die handler is supposed to be dangerous, (see the Camel) CGI scripts do it to allow errors to the browser. You can achieve the same effect by wrapping die. sub mydie{#do stuff; die $_[0];}
  • my $caller =$ENV{CALLER_ID}; How do you know this environment variable is set at this point in your script?
  • $filename ...should perhaps be a $CONSTANT at the top of your file
  • You might look at past flower box discussion