Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
# Define our buckets for collecting data my %bucket = (); my %USER = (); my %VIRUS = (); my %SPAM = ();
my creates a variable in an empty state. Assigning emptiness to an empty container is redundant.
# These numbers must be valid reason codes... my @wanted = ( 1, 60 );
It would be more efficient to use a hash instead of an array there.
for (<$file>)
A for loop iterates over a list which means that the entire contents of the file have to be stored in a list in memory before it can be iterated over. It is more efficient to use a while loop which only reads one line at a time.
while ( <$file> )
chomp; my ( $month, $day, $time, $host, $process, $clientIP, $MessageID, $timeStart, $timeEnd, $service, @INFO ) = split /\s+/;
The chomp is superfluous because split /\s+/ removes all whitespace. You are declaring eleven variables but you are only using three. You can use undef as a placeholder:
my ( undef, undef, undef, $host, undef, undef, undef, undef, undef, $s +ervice, @INFO ) = split;
$USER{$host}{$recip}{$action{$service}{$action_}}{$reason{$rea +son_}}{'count'}++; #if ( grep /^$reason_$/, @wanted );
If you had used a hash for wanted then you would not need to use grep.
$USER{$host}{$recip}{$action{$service}{$action_}}{$reason{$rea +son_}}{'count'}++; #if exists $wanted{ $reason_ };

In reply to Re: spamstats.pl by jwkrahn
in thread spamstats.pl by tcf03

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others pondering the Monastery: (2)
As of 2024-04-26 03:40 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found