There are two errors in the code:

my $normalized = my $numdiv / $numden;
[download]

You declare $numdiv again with my, resetting it's value, this should have produced a warning.

foreach my $element(@array) {    # loop over args
    ... 
    my $normalized = my $numdiv / $numden; # normalize
}
return $normalized;
[download]

You make a $normalized variable local to the loop and try to return it outside, this shouldn't compile with strict vars.

Using warnings and strict will help you catch simple mistakes like these.

You can use $element to modify the array (it is an alias, not a copy). $numden is not dependent on the array element, so there is no need to calculate it each time.

This should work:

use List::Util qw( min max );

sub normalizer {
    my @array = @_;

    my $min_numarray = min @array;
    my $max_numarray = max @array;

    my $numden = $max_numarray - $min_numarray;
    foreach my $element (@array) {
        my $numdiv = $element - $min_numarray; 
        $element = $numdiv / $numden;
    }

    return @array;
}
[download]

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.