Beefy Boxes and Bandwidth Generously Provided by pair Networks
We don't bite newbies here... much
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Hello

in addition to what has already been said about doing multiple times things that can be done only once (reading files many times, etc.), and although this is not directly what you are asking for, I would strongly recommend some changes to your coding style. Especially, you've got a lot of repeated code. Just to take an example, this big 30-line while loop:

while (my @line=split (/\t/,<SEQ>)){#for each sequence record +the nmer information my $ct=0; my $start=$line[1]; if ($start < $line[2]){##Watson Strand # ... } else{##Crick Strand # ... } }

is coming twice, with identical or almost identical code. Put that in a separate subroutine which you call then twice where you need. This will remove about 60 lines from your main code and make it much shorter and far easier to follow. It will also make it easier to figure out possible performance improvements. And, last but not least, if you have a bug in that code or need to re-factor it, you will need to correct it only once.


In reply to Re: Code Optimization by Laurent_R
in thread Code Optimization by azheid

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others romping around the Monastery: (3)
As of 2024-04-26 01:09 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found