You're using an old syntax there. I recommend that you read perldoc perlmod in a modern perl. It will help you would quite a bit.

As for the warnings, those variables are probably used somewhere in your "cfg.pl" program. The warning occurs because you have required that module (which happens are run time) and when Perl parses your CFG variables, it doesn't see (yet) that they've been used elsewhere. Hence the warning. There are several ways to get around this. One of the easier to implement and understand ways: (switching the old single quote package name delimiter to double colons):

use strict;
use warnings;
require "cfg.pl";
require "db.pl";
my $db;
{
    no warnings 'once';
    $db = new DB($CFG::SERVER, $CFG::DB, $CFG::USER, $CFG::DBPASSWD)
};
[download]

(I assumed, possibly incorrectly, that the password was also from that file and you just typoed it.)

What I would recommend to deal with the is to convert your .pl files to proper modules and then use them. The syntax would then look something like:

use strict;
use warnings;
use Cfg;
use Db;

my $db = new DB($CFG::SERVER, $CFG::DB, $CFG::USER, $CFG::DBPASSWD);
[download]

There are a few other things to look at, but I think this is a good start.

Cheers,
Ovid

New address of my CGI Course.

Having said that, your program contains the mentioned variables once. Since it's possible in Perl to use a variable without declaring it, a typo in a variable name is still a valid program. Therefore, at compile time, Perl issues a warning if it sees a variable that's used only once - it's a strong indication the programmer made a typo.

I presume that either cfg.pl or db.pl set the variables?

Perhaps the best way to deal with this is to get rid of the perl4 style of coding, and use perl5 style of coding. Use use to include the other files, and export (using Exporter) the variables to the calling program.

Other alternatives: mention the variables elsewhere in your file, or turn the specific warning off using lexical warnings.

Abigail