Passing vars to command

Anonymous Monk has asked for the wisdom of the Perl Monks concerning the following question:

Hi

Sorry to be a pain, but i have something that is probably simple for most of you, but a real pain for me.

I have the variables:
$password (contains password) $domain (contains domain name e.g bar.com) $username (contains users name) $fullname (contains something like billy bob, but needs to be passed as "billy bob")<br
and they need to be passed like this:
AddVirtUser tpasswd=$password $domain $username $fullname 500 0 0 0

(The 500 specifies user disk quota, and the 0 0 0 specifies whether the user can use telnet,ftp,smtp)

my current code looks like this:


if(system('/usr/local/bin/AddVirtUser' => 'tpasswd=$password',
                                           $domain,
                                           $username,
                                           $fullname,
                                           '500',
                                           '1 1 1',
   )){
[download]

Comment on Passing vars to command Download Code

Replies are listed 'Best First'.
Re: Passing vars to command by trs80 (Priest) on Sep 30, 2002 at 21:18 UTC
Your single quotes are making it send $password not the value of $password, try this instead. `if(system('/usr/local/bin/AddVirtUser',"tpasswd=$password", $domain, $username, $fullname, '500', '1','1','1' )){` [download]	[reply] [d/l]
Re: Passing vars to command by flounder99 (Friar) on Oct 01, 2002 at 11:31 UTC
Other than the quoting problem on your password you might look at the last part. When using the list form of the `system` command there is a big difference between calling the external program using `system "foo", "1 1 1"` and `system "foo", "1","1","1"` let me give you and example: `if (@ARGV) { print "called with "; foreach (@ARGV) { print "'$_' "; } print "\n"; } else { system ('perl', $0, "foo", "bar", "baz"); system ('perl', $0, "foo bar baz"); #single parameter system ("perl $0 foo bar baz"); system ("perl $0 'foo bar baz'"); } __OUTPUT___ $ perl temp.pl called with 'foo' 'bar' 'baz' called with 'foo bar baz' called with 'foo' 'bar' 'baz' called with 'foo bar baz'` [download] As you can see the first form calls the external program with three separate parameters `'foo', 'bar', 'baz'`. The second form calls the program with one parameter `"foo bar baz"` These are very different and the external program may act completely different depending on what it expects. -- flounder	[reply] [d/l] [select]
Re: Passing vars to command by Aristotle (Chancellor) on Sep 30, 2002 at 21:12 UTC
And what's the question? Looks fine as it is.. Makeshifts last the longest.	[reply]
Re: Re: Passing vars to command by Anonymous Monk on Sep 30, 2002 at 21:13 UTC
it doesn't seem to be passing the password over.	[reply]
Re^3: Passing vars to command by Aristotle (Chancellor) on Sep 30, 2002 at 21:18 UTC
Now there's one. And duh at myself of course. You need to put the parameter in double quotes since single quotes don't interpolate variables: `"tpasswd=$password"`. (Or maybe use the `qq` "operator", which allows to choose your own delimiters like in `qq(tpasswd=$password)`.) Makeshifts last the longest.	[reply] [d/l] [select]


Think about Loose Coupling
	PerlMonks