Beefy Boxes and Bandwidth Generously Provided by pair Networks
XP is just a number
 
PerlMonks  

Re^3: Perl::Critic says don't modify $_ in list functions and other things

by ikegami (Pope)
on Jul 12, 2020 at 14:51 UTC ( #11119219=note: print w/replies, xml ) Need Help??


in reply to Re^2: Perl::Critic says don't modify $_ in list functions and other things
in thread Perl::Critic says don't modify $_ in list functions and other things

Would any line produced by evaluating the <$fh> expression ever end in \r\n?

On Windows? It would require CR CR LF in the file (assuming default $/ and IO layers). Extremely unlikely.

Elsewhere? It would require CR LF in the file (assuming default $/ and IO layers). Possible.

I think s{ $/ \z }{}xms would work

Well, that should be s{ \Q$/\E \z }{}xms (and /m and /s are useless) to be equivalent to the chomp.

And if $/ hasn't been changed, s/\n\z// could be used (since $/ defaults to LF on all systems).

But if I was going with a regex pattern, I'd go with s/\s+\z//. Handles \n, \r\n and other trailing whitespace. (TSV files being an exception.)

Log In?
Username:
Password:

What's my password?
Create A New User
Node Status?
node history
Node Type: note [id://11119219]
help
Chatterbox?
and the web crawler heard nothing...

How do I use this? | Other CB clients
Other Users?
Others exploiting the Monastery: (10)
As of 2021-01-15 21:16 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?
    Notices?