Re^4: eval "require $class" seems wrong (--!$@)

in reply to Re^3: eval "require $class" seems wrong (--!$@)
in thread eval "require $class" seems wrong

The 1 is useless since require always returns true. (If it encounters no error, it returns what the module returns. If the module returns false, it encountered an error. If it encounters an error, it throws an exception.)

Comment on Re^4: eval "require $class" seems wrong (--!$@) Select or Download Code

Replies are listed 'Best First'.
Re^5: eval "require $class" seems wrong (1) by tye (Sage) on Aug 22, 2007 at 19:23 UTC
Yes, and the space is equally "useless" because `require"$file.pm"` works just fine. That doesn't mean I'm going to drop either of them. The "; 1" is part of the best practice. It may not change the effect of this particular code, but it means I don't have to worry about whether the preceeding code might return a false value rather than dieing. It also tells the reader that I'm testing whether eval succeeded not whether the eval'd code returned a true value (which also makes it clearer why I'm using eval at all). - tye	[reply] [d/l]

Replies are listed 'Best First'.

Re^5: eval "require $class" seems wrong (1)
by tye (Sage) on Aug 22, 2007 at 19:23 UTC

Yes, and the space is equally "useless" because require"$file.pm" works just fine. That doesn't mean I'm going to drop either of them.

The "; 1" is part of the best practice. It may not change the effect of this particular code, but it means I don't have to worry about whether the preceeding code might return a false value rather than dieing. It also tells the reader that I'm testing whether eval succeeded not whether the eval'd code returned a true value (which also makes it clearer why I'm using eval at all).

- tye

[reply]
[d/l]

In Section Seekers of Perl Wisdom