http://qs321.pair.com?node_id=575529

texasperl has asked for the wisdom of the Perl Monks concerning the following question:

Hi. I'm more or less new to perl, and while this code is functional and it does what I want it to do...my question is, is this the "best" way? Are there some additional caveats and/or shortcuts I could be using here?
my $srcdir = '/var/local/some_dir/'; my $mtime = '1'; my $destdir = '/backup/some_dir/'; unless (-d $srcdir && -d $destdir ) {die "Error: $!";} print "Beginning backup...\n"; chdir $srcdir; opendir(INDIR,$srcdir) || die "Can't open directory: $!"; my @files = readdir(INDIR); closedir (INDIR); foreach (@files) { unless (-d || $_ eq "." || $_ eq "..") { if (-M > $mtime) { print "$_ : Older than one day.\n"; } else { `tar -cz $_ -f $_.tar.gz`; `mv *.gz $destdir`; print "$_ archived in $destdir\n"; } } }
Many thanks in advance.

2006-09-30 Retitled by planetscape, as per Monastery guidelines: one-word (or module-only) titles hinder site navigation

( keep:1 edit:22 reap:0 )

Original title: 'Elegance?'