http://qs321.pair.com?node_id=505999


in reply to Hard-coded colors breaking custom CSS settings.

Rest assured, I don't think anyone's hard-coding any new colors. There are just some old ones lingering. I got rid of most of these a few years back, but I know I didn't get all of them; it's a big codebase. If you find something like this, and it's causing you trouble, /msg me the details and I'll see about getting rid of it. If, after a week or so, it's not fixed, and you haven't heard bad news from me, /msg me again. I don't mind a bit of polite hassling. :-) You might also talk to the pmdev folks, who might respond more quickly. If a patch is brought to my attention to do this sort of thing, I'll apply it.

Replies are listed 'Best First'.
Re^2: Hard-coded colors breaking custom CSS settings.
by Aristotle (Chancellor) on Nov 05, 2005 at 18:00 UTC

    Searching the code for <font shows 120 hits, but a bunch of them are irrelevant, and I don’t know how many of them are dead. Even so, if each pmdevil patched one or two of those, they’d all be gone. It’s less work than meets the eye.

    I’m in the process of patching all the poll stuff.

    Makeshifts last the longest.

Re^2: Hard-coded colors breaking custom CSS settings.
by wolfger (Deacon) on Nov 06, 2005 at 11:24 UTC

    Well, here's one where the colors don't seem to be hardcoded, but I'm not seeing the words anyhow:

    <tr class="titlebar"> <td class="titlebar"> <form method="get" action="?" enctype="application/x-www-form-urlencoded" > <img src="./images/clearpixel.gif" width="5" height="1" alt="" class="spacer" /> <input type="text" name="node" size="20" maxlength="80" /> <input class="titlebar" type="submit" value="Search" name="go_button" /> </form> </td> <td class="titlebar" id="mb2001titlebar" align="right" > <a class="titlebar" href="?" > Perl&nbsp;Monks </a> </td> </tr>

    And my CSS:

    tr.titlebar , tr.monkquip { color : #0000aa; background-color : #ffffff; }

    The funny think is, the monkquip displays properly, but the titlebar does not.

      Try either less or more specifity. Either just .titlebar, so all elements with the class are addressed directly (instead of having to inherit their colours from the <tr>), or add a couple more specific ones like td.titlebar, input.titlebar.

      Specificity is a pretty important concept in CSS, and if you don’t understand it, then the cascading and inheritance of things will occasionally snare you in baffling ways.

      Makeshifts last the longest.