http://qs321.pair.com?node_id=11122163


in reply to Re: RFC: How did I do writing my first test?
in thread RFC: How did I do writing my first test?

Testing files that end with newlines was suggested here. I would remove those tests and happily only have one temp file for all the tests.

I am having a hard time visualizing the tests in subroutines. I am also willing to expand the variable names. I was being a bit lazy when I wrote them. ($n_fh, $n_file) becomes ($newline_fh, $newline_file); ($no_n_fh, $no_n_file) becomes ($no_newline_fh, $no_newline_file). However, if the tests for files ending with a newline are removed, I will just use the ($fh, $fn) from line 84. I will push the test with the expanded variable names shortly after posting this.

I will think about changing the name, however, I do not like the word slurp.

Putting my POD in separate files came about several weeks ago. I was writing up usage of a site specific module for myself, finally, in a separate file. I was going to save it as text. All it needed was a little formatting, so I added the POD formatting to it. I saved it as .pod, committed it, and pushed it to GitHub. Out of curiosity, I looked at it on GitHub and was happy to see the POD was rendered into HTML. Since it is easier to read when rendered as HTML, I decided to do it for all my modules. The only time I ever read a Perl document with perldoc is when I am checking to see what my POD looks like. Otherwise, I read the Perl and module documentation in a browser (perldoc.perl.org or metacpan.org). So, since GitHub will render .pod as HTML, making it easier to read, I thought to myself, "Why not?". Also, perldoc My::Module still works whether the POD is embedded or separate. I checked.

My OS is Debian 10 (Buster); my perl versions are 5.28.1 local and 5.16.3 or 5.30.0 on web host depending on the shebang.

No matter how hysterical I get, my problems are not time sensitive. So, relax, have a cookie, and a very nice day!
Lady Aleena

Replies are listed 'Best First'.
Re^3: RFC: How did I do writing my first test?
by Arunbear (Prior) on Sep 25, 2020 at 13:12 UTC
    Using subroutines could be something as simple as 
    sub test_encodings {
    my ($fh, $fn) = tempfile();
    $fh->print($file_string);
    $fh->close();

    is_deeply(
      [ Fancy::Open::fancy_open($fn) ],
      [ map encode('utf8', $_), @wanted_array ],
      "testing an array opened with no encoding"
    );

    my @encodings = qw(UTF-8 ascii cp1252 iso-8859-1);

    for my $encoding (@encodings) {
      is_deeply(
        [ Fancy::Open::fancy_open($fn, { 'encoding' => $encoding }) ],
        [ map encode($encoding, $_), @wanted_array ],
        "testing an array opened with $encoding encoding"
      );
    }
}

sub test_with_file_that_ends_with_a_newline {
    my ($fh, $fn) = tempfile();
    $fh->print("$file_string\n");
    $fh->close();

    is_deeply(
      [ Fancy::Open::fancy_open($fn) ],
      [ @wanted_array ],
      "testing a plain array with file that ends with a newline"
    );

    is_deeply(
      [ Fancy::Open::fancy_open($fn, { 'before' => 'solid ' }) ],
      [ @solid_array ],
      "testing an array with before option with file that ends with a 
+newline"
    );

    is_deeply(
      [ Fancy::Open::fancy_open($fn, { 'after' => ' bead' }) ],
      [ @bead_array ],
      "testing an array with after option with file that ends with a n
+ewline"
    );

    is_deeply(
      [ Fancy::Open::fancy_open($fn, { 'before' => 'solid ', 'after' =
+> ' bead' }) ],
      [ @solid_bead_array ],
      "testing an array with before and after options with file that e
+nds with a newline"
    );
}

    [download]
    As bonuses, the file name/handle variable names are uniform, and the section comments are made redundant by the sub names.

    On second thought, "slurp" (in Perl land) means reading a file into a scalar, whereas you're reading into an array, so "fancy_read_lines" is still more accurate than the current name.

    I didn't realise GitHub could automatically render .pod files - that is cool.

[reply]
[d/l]

In Section Seekers of Perl Wisdom