in reply to Re^2: Perl::Critic says don't modify $_ in list functions and other things
in thread Perl::Critic says don't modify $_ in list functions and other things
I made a few changes to the conditionals around the eval code to possibly keep mistakes from happening when it is used, but I still can't figure out how to convert the eval EXPR into an eval BLOCK. Like converting a map or grep EXPR to a BLOCK, it isn't as easy as putting {} around it instead of () and expecting it to work the same.
if ($raw_value && $raw_value =~ /\d+\*\d+/) { $total_value = eval($raw_value); # performs multiplication ($amount, $base_value) = split(/\*/,$raw_value); } elsif ($raw_value && $raw_value =~ /\d+\/\d+/) { $base_value = eval($raw_value); # performs division ($total_value, $amount) = split(/\//, $raw_value); } else { $amount = $raw_value; $base_value = $assets->{$lookup_asset} ? $assets->{$lookup_asset} +: 0; $total_value = $amount * $base_value; }
My OS is Debian 10 (Buster); my perl versions are 5.28.1 local and 5.16.3 or 5.30.0 on web host depending on the shebang.
No matter how hysterical I get, my problems are not time sensitive. So, relax, have a cookie, and a very nice day!
Lady Aleena
|
---|
Replies are listed 'Best First'. | |
---|---|
Re^4: Perl::Critic says don't modify $_ in list functions and other things
by hippo (Bishop) on Jul 10, 2020 at 08:22 UTC |
In Section
Seekers of Perl Wisdom