comment on

A few formatting comments:

I think qq and combined statements are clearer here:

    if ($shpath) {    
      #print SH "chmod 700 $shpath/shell_$ts.sh\n";
      #print SH "$shpath/shell_$ts.sh\n";
      #print SH "rm $shpath/shell_$ts.sh\n";
      #push @cmd, "pscp -pw \"${passwd}\" \"${shell}\" ${user}\@${serv
+er}:${shpath}/shell_$ts.sh\n";
      #push @cmd, "plink -batch -pw \"${passwd}\" ${user}\@${server} -
+m \"${sh}\" >> \"${output}\" 2>${outerr}\n";
      print SH "chmod 700 $shpath/shell_$ts.sh\n",
               "$shpath/shell_$ts.sh\n",
               "rm $shpath/shell_$ts.sh\n";
      push @cmd, qq[pscp -pw "${passwd}" "${shell}" ${user}\@${server}
+:${shpath}/shell_$ts.sh\n],
                 qq[plink -batch -pw "${passwd}" ${user}\@${server} -m
+ "${sh}" >> "${output}" 2>${outerr}\n];
    } else {
      ...
[download]

You have many "if it begins with X, trim off X" cases that can be simplified:

      #if ($sqlline =~ /^=/) {        # Convert the output to record v
+iew if prefixed by =
      #  $sqlline =~ s/^=//;          # trim off the =
      if ($sqlline =~ s/^=//) {       # trim off '=' and convert recor
+d view if prefixed by =
        $rsql = 1;
      }
[download]

And maybe:

    #$server   =~ s/\s+.*//;
    #$user     =~ s/\s+.*//;
    #$passwd   =~ s/\s+.*//;
    #$dbconn   =~ s/\s+.*//;
    #$dbuser   =~ s/\s+.*//;
    #$dbpasswd =~ s/\s+.*//;
    #$shpath   =~ s/\s+.*// if $shpath;
    map{$_ && s/\s.*//} $server,$user,$passwd,$dbconn,$dbuser,$dbpassw
+d,$shpath;
[download]

In reply to Re: SQL script processor and executor by hbm
in thread SQL script processor and executor by PhilHibbs

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


P is for Practical
	PerlMonks