One of the key concepts of programming that I've read is to try to keep classes and the like focused; try to keep interfaces simple and don't fit too many things into one class that probably won't be needed by more than half your audience.

In particular, I've recently gotten a comment back on my DBI::Pretty module that suggests going beyond this. What I have currently is that the user inputs the SQL using a straightword hash, a keyword and the SQL as key and value, respectively. However, the comment suggested an number of other ways to enter this data, such as from a file, from XML, or other ways. These are certainly not unreasonable in terms of their usability for the intended use of the class, however, I'm concerned with the fact that 1) these will increase the size of the class and 2) the user can 'easily' preparse the needed hash from these items themselves.

Now, I'm thinking that it might be possible to create subModules (DBI::Pretty::ModNameHere), which are only loaded if what the user passes it is anything but a hash but meets the needed requirements, eg:

if ( $arg is a FILEHANDLE ) {
    use DBI::Pretty::File;
    %hash = read_stuff_from_file( $arg );
} elsif ( $arg is a XML datastream ) {
    use DBI::Pretty::XML;
    ...
} etc.
[download]

Though I'm not sure of the usability of 'use' in the blocks, and will this code be around after the block is removed. But the key thing here is that if one uses just the needed hash, no extra code would be needed, only in cases of other methods would it be loaded. But again, in this case, is it not already reasonable that the user can get the data in the format as needed?

---

Dr. Michael K. Neylon - mneylon-pm@masemware.com || "You've left the lens cap of your mind on again, Pinky" - The Brain

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.