Beefy Boxes and Bandwidth Generously Provided by pair Networks
Perl: the Markov chain saw
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

Add error checking to your open statements. You are only referencing the filename and not the full path, so it can't find the file.

The following is how I'd clean up your script:

#!/usr/bin/perl #regexp.pl use File::Spec; use strict; use warnings; print "Gimme the address of the directory:\n"; chomp(my $folder = <>); print "What's the phrase you're looking for?\n"; chomp(my $find = <>); my @found; opendir my $dh, $folder or die "Can't open $folder: $!"; while (my $file = readdir($dh)) { next if $file =~ /^\.+$/; my $path = File::Spec->catfile($folder, $file); next if ! -f $path; open my $fh, $path or die "Can't open $path: $!"; my $data = do {local $/; <$fh>}; close $fh; if ($data =~ /\Q$find\E/i){ push @found, $file; } } close $dh; print "Your query was found in the following files:\n"; print "@found\n";

In reply to Re: Tricky regexp by wind
in thread Tricky regexp by riceboyyy

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others having an uproarious good time at the Monastery: (4)
As of 2024-04-19 03:13 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found