This is what I came up with. It does essentially the same as
your program, but it's a little bit shorter. Notice that I
dropped the close altogether, because open automatically
closes the file handle if it was previously opened (see
perlopentut
-- I wouldn't consider this a good programming
practice, but I'm assuming this is a one-shot program here),
so you don't have to keep track of whether file is open. Also,
you don't need to read the whole file in memory at once.
use strict;
my $n="0000";
while (<>) {
if (/^<\?xml version/) {
open OF, ">outfile_$n.xml" or die "open: $!\n";
$n++;
}
print OF $_;
}
--ZZamboni
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|