comment on

Fixing the bug or the limitation? Fixing the bug is simple:

--- LCSS_XS.xs.orig     2010-01-28 14:00:25.000000000 -0500
+++ LCSS_XS.xs.new      2010-01-28 14:03:45.000000000 -0500
@@ -10,8 +10,8 @@

 void
 _compute_all_lcss(s, t)
-       char *  s
-       char *  t
+       SV *    s
+       SV *    t
 PROTOTYPE: $$
 ALIAS:
     lcss = 1
@@ -21,7 +21,7 @@
     int i;
     AV * ra;
 PPCODE:
-    res = _lcss(s,t);
+    res = _lcss( SvPVbyte_nolen(s), SvPVbyte_nolen(t) );
     if (res.n <= 0) {
         _free_res(res);
         XSRETURN_UNDEF;
[download]

It turns out there are two limitations:

It can only compare strings of bytes
It can only compare strings that don't contain byte 00. (It and anything after it is ignored.)

In reply to Re^4: Does String::LCSS work? by ikegami
in thread Does String::LCSS work? by BrowserUk

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


The stupid question is the question not asked
	PerlMonks