I guess we can start by getting rid of the useless variable and shorten the silly pattern.
my $split = join '/', split //, $id;
substr($split, -2, 2, '');
my $url = "$base_url/$split/$id/$id-h/$id-h.htm";
Two lines to calculate and one line to assemble. I don't think length is really a problem here. We're dealing with readability issues if we try to shorten it any more. These are just too complicated:
substr( ( my $split = join '/', split //, $id ), -2, 2, '');
my $url = "$base_url/$split/$id/$id-h/$id-h.htm";
( my $url = join '/', split //, $id ) =~
s{(.*)/}{$base_url/$1/$id/$id-h/$id-h.htm}s;
I'm partial to this *longer* version:
my $url = join('/',
$base_url,
$id =~ /(.)(?=.)/sg,
$id,
"$id-h",
"$id-h.htm"
);
The flow is very simple, so it's easy to understand.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.