I would avoid both of those approaches. The first involves too much repetition of code, and the second is too obfuscated. How about like this:
my ( $src, $dst ) = ( $opt_reverse ) ? ( 0, 1 ) : ( 1, 0 );
if ( $opt_ignore ) {
$map{lc($array[$dst])} = $array[$src];
} else {
$map{$array[$dst]} = $array[$src];
}
(I hope I got the polarity right on what "reverse" means, but in any case, I think you can see the point.)
(update: got rid of the "defined()" call -- the option values should just be true or false, and undefined is false)
Another update: better solution:
my ( $src, $dst ) = ( $opt_reverse ) ? (0,1) : (1,0);
my $key = ( $opt_ignore ) ? lc($array[$dst]) : $array[$dst];
$map{$key} = $array[$src];
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|