comment on

oko1,
Recently, I was thinking about that example in the docs where they demonstrate a method for inserting commas into a numerical string.

You mean the one from perlfaq5?

but that thing is just clumsy and awful and obfuscated for any Perl beginner. So, just for my own entertainment, I decided to see how I'd do it "for real" - i.e., in the best way possible rather than by this contrived method.

I agree that many of the solutions in the FAQ are written more as a cook book rather than as a tutorial. On the other hand, do you honestly feel that your solutions are any better if your target audience is a perl beginner?

If that is your target audience, I would have gone with something a bit more verbose.

Return undef if input is not numeric - perhaps using Scalar::Util's looks_like_number()
Return input in tact if it shouldn't be commified (Inf, NaN, already commified, etc) - perhaps using a different sub
Perform commification in step-by-step atomic units of work

Since it seems your intended goal was to educate beginners, each step should be preceded by the appropriate amount of comments. It may not be obvious what a regex is doing so you could recommend YAPE::Regex::Explain. They may not have considered edge cases, so rather than incorporate them into a single step that is doing something else - break it out on its own statement.

Cheers - L~R

In reply to Re: Commifying sensibly by Limbic~Region
in thread Commifying sensibly by oko1

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


Problems? Is your data what you think it is?
	PerlMonks