Beefy Boxes and Bandwidth Generously Provided by pair Networks
Don't ask to ask, just ask

comment on

( #3333=superdoc: print w/replies, xml ) Need Help??
One of the things a like about testing/tests/test suites/coverage stats is that it can sometimes1 (often?) cause re-evaluation of how you wrote some specific piece of code.

I recently wrote a snippet of code of this form:
sub foo { my $s = shift; if( $s =~ /^(AAA|BBB|CCC)$/ ){ my $foo = $HASH{$1}; my $bar = bar($s); ... } }
While there could easily style/preference (or efficiency) arguments made about this form and use of the regex to match for multiple exact matches, it's nice because it's concise and easy to add an extra case or two (i.e. not an extra line, though obviously adding more than just a couple would be messy).

I found myself wanted to rewrite it, however, for a different reason after starting to compose my test suite. A test suite consisting of a call to foo('AAA') and foo('DDD') is sufficient for Devel::Cover to report 100% coverage. But clearly it's not going after the 'BBB' or 'CCC' of the conditional that's embedded in the regex logic.

If, however, it's rewritten as:
if( $s eq 'AAA' || $s eq 'BBB' || $s eq 'CCC' ){ ... }
or (depending on the innards of the block)
if( $s eq 'AAA' ){ ... }elsif( $s eq 'BBB' ){ ... }elsif( $s eq 'CCC' ){ }
then it requires tests of foo('DDD'), foo('AAA'), foo('BBB'), and foo('CCC') for full coverage.

1. Two other examples of coverage issues causing code changes that i've run into:

In reply to coverage influencing form by davidrw

Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":

  • Posts are HTML formatted. Put <p> </p> tags around your paragraphs. Put <code> </code> tags around your code and data!
  • Titles consisting of a single word are discouraged, and in most cases are disallowed outright.
  • Read Where should I post X? if you're not absolutely sure you're posting in the right place.
  • Please read these before you post! —
  • Posts may use any of the Perl Monks Approved HTML tags:
    a, abbr, b, big, blockquote, br, caption, center, col, colgroup, dd, del, div, dl, dt, em, font, h1, h2, h3, h4, h5, h6, hr, i, ins, li, ol, p, pre, readmore, small, span, spoiler, strike, strong, sub, sup, table, tbody, td, tfoot, th, thead, tr, tt, u, ul, wbr
  • You may need to use entities for some characters, as follows. (Exception: Within code tags, you can put the characters literally.)
            For:     Use:
    & &amp;
    < &lt;
    > &gt;
    [ &#91;
    ] &#93;
  • Link using PerlMonks shortcuts! What shortcuts can I use for linking?
  • See Writeup Formatting Tips and other pages linked from there for more info.
  • Log In?

    What's my password?
    Create A New User
    and the web crawler heard nothing...

    How do I use this? | Other CB clients
    Other Users?
    Others perusing the Monastery: (4)
    As of 2020-11-29 20:28 GMT
    Find Nodes?
      Voting Booth?

      No recent polls found