You XP whore you!
OK, I have just one comment on the use of XML::Twig
(besides stating that this is how I use it myself
most of the time): if you go through the pain of
putting my ($t, $node) = @_; at the
top of the anonymous sub you might as well use
$node in the body:
NODE => sub { my ($t, $node) = @_;
my $nodeid = $node->att ('id');
!exists ($nodehash {$nodeid}) or croak "N
+ode $nodeid is duplicated!";
$nodehash {$nodeid} = {'nodeid' => $nodei
+d,
'title' => $node-
+>text,
'rep' => $node-
+>att ('reputation'),
'last' => $node-
+>att ('reputation'),
'date' => $node-
+>att ('createtime')
};
$t->purge;
}
Also I found that -h does not work (-? does,
you should check $args{h} on line 87, and I usually
use $0 instead of hard-coding the name of the script
in usage().
Good job anyway, it seems to be much faster than the previous version,
4 to 5 times faster actually!
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|