The second feels the cleaner approach to me as well, but it is not correctly implemented. So I suppose one could argue it is too clever. Alternatively, one could fix it:
sub ripper2b { ## Second implementation, take b
my $file = $_;
return unless s/\.(?!$ext)\w+$//i;
my $priority = "$_.$ext";
if (-e $priority && !-d $priority) {
$nom += unlink $file;
}
}
My two fixes:
- (?!$ext) is zero-width, so (?!$ext)$ is just $. We need to remove the extension as well, whatever it is, so add \w+ to the regex.
- The "." was removed by the substitution, so we need to add it again along with $ext.
If that does not make sense to you, the second implementation is just too clever. Go with the first.
print "Just another Perl ${\(trickster and hacker)},"
The Sidhekin proves Sidhe did it!
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|