comment on

Greetings Monks,

Recently I have setup a subversion per-commit hook to check perl source code for certain coding standards, via Perl::Critic. One of the option is to check if the code has been run thru Perl::Tidy (Perl::Critic::Policy::CodeLayout::RequireTidyCode). Im using Perl::Critic thusly ...

#internal method to get file content of this commit
my $content = read_file_content($file_name);
my @violations = critique({-profile => 'perlcritic.conf'}
, \$content);
    
# report violations
foreach my $crit (@violations){
    print STDERR "[$file_name] " . $crit->to_string . "\tsource: " . 
$crit->source . "\n";
}
[download]

and the perlcritic.conf:

[CodeLayout::RequireTidyCode]
perltidyrc = /svn/hooks/perltidy.conf
[download]

and the perltidy.conf

-bl     # braces on new lines
-l=80 #80 col width
-i=4  #4 char per indent
-ce    # cuddled else
[download]

and one of the test commits had the following code:

....
if(1)
{
 print "1";
}
else
{
 print "2";
}
...
[download]

among other violations, such as unindented code and code crossing 80 columns etc.

I have read the perldocs and was sure this case would be reported as an violation, however it didn't. How do I configure the Perl::Critic's profile to report violations on code that fail Perl::Tidy ?

update: changed the title

In reply to Perl::Critic and Perl::Tidy by InfiniteLoop

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


No such thing as a small change
	PerlMonks