I assume your snippet is intended to go inside the OP's for loop:
foreach my $i ( 0..$#data ) {
my %keys = keys %dataPos; # Changed hash name to match hash OP is
+building
my $hkey = $data[$i]; # Changed data lookup to array to match O
+P code.
if ((my @found = grep /^$hkey$/, %keys) > 1) {
$hkey .= '_';
}
$dataPos{$hkey} = $i;
print "$data[$i] -- > $i\n";
}
After I tweaked your code to work with the OP's code, there are still problems. You have a unnecessary nested loop that will grow with each pass through the outer loop. Also, if a key shows up three or more times, the last value will overwrite the value stored for the second key.
I've fixed these issues below.
foreach my $i ( 0..$#data ) {
my $key = $data[i];
# append '_' until no matching key exists.
while ( exists $dataPos{$key} ) {
$key .= '_';
}
$dataPos{$key} = $i;
print "$key -- > $i\n";
}
Even after its been fixed, I still wouldn't use this approach. I'd store repeated values in arrays as other posters have suggested.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|