Well, as an aside ... if you pass that many parameters to a subroutine, have you considered using a hash and using name => value pairs? That would greatly reduce the risk of errors and makes all these variable declarations unnecessary ...

I was thinking of something like the following ... suitably adjusted to your concrete requirements of course (are all parameters necessary, should they get a default value if not given, ...)

# call the sub
my_sub(userid => 'foo', password => 'bar');

sub my_sub {
  my %default_values = (userid => 'user', password => 'passwd');

  my %param = (%default_values, @_);

  print $param{userid}, $/;
  print $param{password}, $/;
  # ...
}

# or with all required arguments
sub my_sub {
  my @required = qw/userid password/;
  my %param = @_;

  for my $req (@required) {
    die "Subroutine my_sub called without required parameter: $req"
      unless exists $param{$req};
  }

  print $param{userid}, $/;
  print $param{password}, $/;
  # ...
}
[download]

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.