Hi. I'm more or less new to perl, and while this code is functional and it does what I want it to do...my question is, is this the "best" way? Are there some additional caveats and/or shortcuts I could be using here?

my $srcdir = '/var/local/some_dir/';
my $mtime = '1';
my $destdir = '/backup/some_dir/';

unless (-d $srcdir && -d $destdir ) {die "Error: $!";}

print "Beginning backup...\n";

chdir $srcdir;
opendir(INDIR,$srcdir) || die "Can't open directory: $!";

my @files = readdir(INDIR);

closedir (INDIR);

foreach (@files) {

        unless (-d || $_ eq "." || $_ eq "..") {

                if (-M > $mtime) {
                        print "$_ : Older than one day.\n";
                } else {
                        `tar -cz $_ -f $_.tar.gz`;
                        `mv *.gz $destdir`;
                        print "$_ archived in $destdir\n";
                }
        }
}
[download]

Many thanks in advance.

2006-09-30 Retitled by planetscape, as per Monastery guidelines: one-word (or module-only) titles hinder site navigation

Original title: 'Elegance?'

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.