I think you're not following OOP too close. I would change it to something like this (untested):
sub new {
my ($class, %parameters) = @_;
my $self = {};
# here we check required parameters, to croak() them. since we are
+ using
# OOP, we *need* to ensure this object will be complete to perform
+ whatever
# operations, avoiding coupling.
foreach (qw(cardnum)) { # maybe we have other required parameters
croak "Required parameter '$_' not found"
unless exists $parameters{$_};
}
# now we set defaults for not obligatory parameters
$self->{'tail'} = $parameters{'tail'} || -4;
$self->{'head'} = $parameters{'head'} || 0;
$self->{'replacement'} = $parameters{'replacement'} || "*";
}
sub obscure {
my ($self) = @_;
my $obscured = substr($self->{'cardnum'},
$self->{'head'},
$self->{'tail'}
) =~ s/./$self->{'replacement'}/g;
return $obscured;
}
Hope this helps.
Igor 'izut' Sutton
your code, your rules.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|