Your x!! approach is nifty, but it's a little hard to read: the double-negation is confusing unless explained, and the x operator seems to be out of place in this context. I have always found one of these easier to read:
my $uri;
foreach (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
If you need to preserve the parts seperately:
my @part = (
'http://example.net/app',
$is_admin_link && 'admin',
$subsite,
$mode,
$id,
$submode,
);
my $uri;
foreach (@parts) {
$uri.="$_/" if ( defined $_ && length($_) ) #omit undef and empties
}
I prefer these because:
- The logic for inclusion of parts is clear
- It makes it easy to apply a common rule to all components (e.g. URL-ify components before concatenation)
- It avoids repetition of code
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.