Just another Perl shrine | |
PerlMonks |
comment on |
( [id://3333]=superdoc: print w/replies, xml ) | Need Help?? |
One way to make code refactoring more palatable to the original authors is to add a lot of useful comments as you 'get to know the code'. I have rarely found existing code to be adequately POD-ed and you could make substantial changes to code under the guise of 'just cleaning up a little while I comment'. Another technique I have used is to apply an OO veneer over non-modular code, changing the things I don't like while talking about it as though it was 'just a minor refactor'. Most developers accept that they could have written their former code better, but there is no need to rub their faces in it. A little politeness never hurt anyone, especially where there are so many different (and sometimes equally valid) ways to solve a problem. Fundamentally, though, you are either responsible for the code or you aren't. If you are, then (in my view) you can do whatever you think best, and there is no need to 'present' your changes to the original authors (who probably don't care and are working on something else). Personally, I would just keep quiet about it, write good documentation that justifies any extensive changes, and treat your predecessors with deference and grace. Above all, don't change anything unless you fully understand and can test it, and don't be afraid to ask for help. No good deed goes unpunished. -- (attributed to) Oscar Wilde In reply to Re: Consideration for others code
by ptum
|
|