Update: davidrw's response above is much simpler. I was responding to the algorithm as posted, and pointing out that your inner loop needed some work :)
You should probably restructure your inner loop, and pull the GenerateTestFileList() call outside of it.
my $count = 0;
foreach (@keywords) {
if( ($_ eq "database.txt") || ($_ eq "keywords_database.txt") ) {
print "Found $_\n";
$count++;
last if($count == 2);
}
}
if($count != 2) {
print "At least one database is missing.\n";
GenerateTestFileList();
}
I would also recommend using the string equality operator (eq) instead of regular expressions. You know exactly what the files are named, and you don't want an accidental match. For example, the strings "random_database.txt" and "some_other_database.txt.tar.gz" will match your elsif(@keywords[$kdbase] =~ /database\.txt/) line above.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|