Beefy Boxes and Bandwidth Generously Provided by pair Networks
Keep It Simple, Stupid
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??
I'd write that as:
use Readonly; Readonly my $LOW => 9; Readonly my $HIGH => 14; ... my $count = $some_variable eq 'x' ? $HIGH : $LOW; for $i (0 .. $count) { ... }
Or
use Readonly; Readonly my %VALUES => (x => 14, y => 9); ... for $i (0 .. $VALUE{$some_variable}) { ... }
a bit depending on whether you need $count elsewhere, and what 9, 14, $some_variable, 'x', 'y' actually stand for.

The main drive of programming it this way is that I strongly dislike 'magical' literals (specially numbers) in the middle of the code. Unless I know the bigger picture, I can't see what the 9 and 14 stand for. Nor do I know whether their values can be changed without having to change the value elsewhere in the program as well. Defining them as constants helps solving this problem.


In reply to Re: Style: buried variables or double referencing? by Anonymous Monk
in thread Style: buried variables or double referencing? by punch_card_don

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others meditating upon the Monastery: (4)
As of 2024-04-20 04:15 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found