Mobious Monks,
Simple style question.
I have a count variable that is to be set depending on a condition:
if ($some_variable eq 'x') {
$count = 14;
}
else {
$count = 9;
}
for $i (0 .. $count) {
do some stuff
}
Wherein '$some_variable' can have the values 'x' and 'y' only.
Coding the actual values right there in the conditonal effectively buries that way down in the bowels of a long program, but uses the minimum lines of code and is highly readbable once you find that snippet.
Setting two value holders at the top of the script make for easier maintenance when the values need to be changed some day:
#constant declaration area at top of script
$value_1 = 14;
$value_2 = 9;
...many lines of code later...
if ($some_variable eq 'x') {
$count = $value_1;
}
else {
$count = $value_2;
}
for $i (0 .. $count) {
do some stuff
}
but it creates double referencing and extra lines of code.
A third way would be to declare a hash:
#constant declaration area at top of script
$count{'x'} = 14;
$count{'y'} = 9;
...many lines of code later...
for $i (0 .. $count{$some_variable}) {
do some stuff
}
Any feelings on which is preferable from a coding style and/or efficiency point of view?
Forget that fear of gravity,
Get a little savagery in your life.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.