Automating things is always a Good Thing™. A few things I find interesting though.
- You use system() to copy a file. Not very Perl'ish ;)
- Setting the "van" and "tm" variables are first stored in an array, then converted to a scalar, why?
- User settings are hardcoded in the script. Shouldn't be a configuration file be easier?
- This script is probably invoked by cron, a "--silent" switch would be nice.
- $sdate (and others) will be in this format: 27-7-5, while "2005-07-27" probably makes more sense to international users.
- Script dies when target start date has not been reached yet. This is a Bad Thing™ for other %users. next would be nicer in the foreach loop.
PS: isn't a BASH script easier for such tasks? ;)
--
b10m
All code is usually tested, but rarely trusted.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|
