I really like this solution, and decided to play around with it a little. Here it is with a little enhancement...
use warnings;
use strict;
my %arith;
$arith{"+"} = sub { $_[0] + $_[1] };
$arith{"-"} = sub { $_[0] - $_[1] };
$arith{"*"} = sub { $_[0] * $_[1] };
$arith{"/"} = sub { $_[0] / $_[1] };
my $problem = "6 + 1";
my $answer;
if (
$problem =~ /^(\d+)\s*(\S)\s*(\d+)$/
and exists $arith{$2}
) {
eval {
$answer = $arith{$2}->( $1, $3 );
}
} else {
die "Oops!\nOperation syntax not understood.\n";
}
die "Woops!\n$@" if $@;
print "$answer\n";
- Modified regexp to require two operands and to make whitespace optional.
- Added basic validity/syntax checking to the results of the pattern match.
- Trapped (and dealt with) possible errors resulting from mathematical operation using the block version of eval. Note, this is the safe version, we're not evaluating quoted text, we're evaluating known code to trap potential errors resulting from mathematical operation errors such as divide by zero.
- Added more robust checking for the existance of a particular mathematical operator in the hashtable.
- Switched to $funcref->(params) notation instead of &$funcref(params).
It's a long way from being a full fledged algeraic expression parser, but it is a little more robust.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|