Hello!
I'm still practise my skill in Perl. I walk slowly, but it's very nice travel by Camel's track.
So, I need some advices about style code.
Look please at this:
To try OO programing in Perl I've made module to calculate how many bills and coins I need to pay for example $133 = (100+20+10+2+1).
It's propably quite helpful for employers.
He can't get 5x$100 from bank for 6 workers ($135 + $80 + $66 + $150 + $69= $500),
but he can do this:
#!/usr/bin/perl
use warnings;
use strict;
use payment;
my @my_bills = qw (200 100 50 20 10 5 2 1);
my @my_payments = qw{135 80 66 150 69};
my $mp = payment->new();
$mp->change(@my_bills);
foreach (@my_payments) {
$mp->add($_);
}
my %result = $mp->get();
foreach ( sort { $b <=> $a } keys(%result) ) {
print "$_ \t: $result{$_}\n";
}
and this is code of payment.pm
package payment;
use warnings;
use strict;
sub new {
my $class = shift;
my $self = {};
$self->{units} = undef;
$self->{bills} = undef;
bless $self, $class;
}
sub change {
my $self = shift;
@{ $self->{units} } = @_;
%{ $self->{bills} } = map { $_ => 0 } @_;
}
sub add {
my $self = shift;
my @units = @{ $self->{units} };
my %pieces = %{ $self->{bills} };
my $temp = shift;
my $unit;
my $i = 0;
while ($temp) {
$unit = $units[$i];
while ( $temp >= $unit ) {
$temp -= $unit;
$pieces{$unit} += 1;
}
last if $i == (@units);
$unit = $units[ ++$i ];
}
%{ $self->{bills} } = %pieces;
}
sub get {
my $self = shift;
return %{ $self->{bills}};
}
1;
So, what do you thing about this? My style is good?
Have you any advices for me? If it's good, I'm going to add some features into my class. ;-)
Thanks for your's advices and time.
Regards
Uksza
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.