Duh, of course. Thanks for catching that. Doing it at the comparison point is wrong though, the real fix is to de-escape the URI encoding for cookie data when it's parsed. That means simply:
--- pmchatter.html.old 2004-12-19 17:05:59.000000000 +0100
+++ pmchatter.html 2004-12-19 17:05:13.000000000 +0100
@@ -17,3 +17,3 @@
var kv = record[ i ].split( /=/ );
- this.data[ kv[ 0 ] ] = kv[ 1 ];
+ this.data[ decodeURIComponent( kv[ 0 ] ) ] = d
+ecodeURIComponent( kv[ 1 ] );
}
@@ -63,3 +63,3 @@
if( userpass.length ) {
- req.setRequestHeader( 'Cookie', 'userpass=' + userpass
+ );
+ req.setRequestHeader( 'Cookie', 'userpass=' + encodeUR
+IComponent( userpass ) );
}
I updated the root node.
Update: it wasn't quite as trivial — need to re-escape the cookie to send it, of course.
Makeshifts last the longest.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|