comment on

if (ref $_[0] eq 'HASH') {
[download]

This seems to a bit of a religious subject, but personally I consider such checks as this to be totally wrong. You probably really want one of the below:

#1
if (eval{ $_[0]->{''}, 1 }) {

#2
use Scalar::Util qw(reftype);
if (reftype $_[0] eq 'HASH') {

#3
if (UNIVERSAL::isa($_[0],'HASH')) {
[download]

I only consider the first to be really robust, the second is fairly robust but could do the wrong thing if the object was actually a different type but had hash overloading semantics. The third is passable, but is easily fooled into causing errors, and the version you used suffers from all of the problems mentioned for my examples as well as the flaw that it plain and simply can't be used with blessed hashes which IMO is just bad design.

Anyway, you may not agree with my POV here, but if you haven't thought your position through on this type of thing its probably worth doing so.

---
demerphq

_{First they ignore you, then they laugh at you, then they fight you, then you win.

-- Gandhi

Flux8}

In reply to Re^2: Trouble getting started with Perl OO (ref $f eq 'HASH' is bad) by demerphq
in thread Trouble getting started with Perl OO by ant

Are you posting in the right place? Check out Where do I post X? to know for sure.
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
Want more info? How to link or How to display code and escape characters are good places to start.


The stupid question is the question not asked
	PerlMonks