For most of the duplication you avoid with your fetch_count function, DBI has a built-in way of avoiding it: whenever you've got a query on which ->fetch_... is only invoked once, you can skip the separate ->prepare and ->execute by using a $db->select_... method.
So the 4 active lines in your function become just 1:
sub fetch_count
{
my ($db, $table) = @_;
$db->selectrow_array("SELECT COUNT(*) FROM $table");
}
It probably isn't worth writing a function for that, since there isn't that much duplication without it:
my $row1 = $dbh->selectrow_array('SELECT COUNT(*) FROM table_one');
my $row2 = $dbh->selectrow_array('SELECT COUNT(*) FROM table_two');
But you could always put it in some sort of loop:
my ($row1, $row2)
= map { $dbh->selectrow_array("SELECT COUNT(*) FROM $_") }
qw<table_one table_two>;
(By the way, I think your ->fetch_arrayref is a typo.)
Smylers
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|