Beefy Boxes and Bandwidth Generously Provided by pair Networks
No such thing as a small change
 
PerlMonks  

comment on

( [id://3333]=superdoc: print w/replies, xml ) Need Help??

A good rule of them i like to apply, is use "if (cond){ block }" only if block is more then one statement.

As for using "A or B" vs "B unless A" .. I like to make the "main" action be the first one, so that people skimming your code get an idea of what you are doing without reading hte whole line. But in the examples you provide, deciding what the "main" action is depends largely on your perception of the greater context...

  • Are you primarily warning about bad input, and the size comparison is a condition of that warning?
  • Are you primarily comparing the size, and the warning is potential result of the comparison?

Given such a short bit of code, it probably doesn't matter much. However, if you were doing a big chunk of input/data validation, with lots of different warnings in differnt cases, I'd use...

warn "blah blah" unless A; warn "yak yak" unless B; warn "bafkjlkajaksjdf;lkjas;kaj;aksdf;kjalkjas;dkf" unless C; warn "blblblblblbblblblblbl" unless (D or E);

if you're doing a lot of processing, and the warning is just an afterthough in one section of hte processing, then i'd use or...

doSomething(); something->else(); third_thing() or warn "something didn't work quite right"; still(processing);

In reply to Re: Style: expr or warn vs. if..warn? by hossman
in thread Style: expr or warn vs. if..warn? by FoxtrotUniform

Title:
Use:  <p> text here (a paragraph) </p>
and:  <code> code here </code>
to format your post; it's "PerlMonks-approved HTML":



  • Are you posting in the right place? Check out Where do I post X? to know for sure.
  • Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
    <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>
  • Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
  • Want more info? How to link or How to display code and escape characters are good places to start.
Log In?
Username:
Password:

What's my password?
Create A New User
Domain Nodelet?
Chatterbox?
and the web crawler heard nothing...

How do I use this?Last hourOther CB clients
Other Users?
Others learning in the Monastery: (5)
As of 2024-04-19 02:07 GMT
Sections?
Information?
Find Nodes?
Leftovers?
    Voting Booth?

    No recent polls found