I agree with tedrek++. The code you show looks fine for syntax.

A few suggestions, however. Your line 135, the first shown, is true unless @results is empty. The usual way to write that is

if (@results) {
    #...
}
[download]

That works because @results is in scalar context there, giving the number of elements. This decision is not strictly necessary, since the for loop will iterate zero times for an empty @results.

The evident duplication of code in your long run of decisions suggests condensing that section into a loop. A hash for the data with the printed terms "Title".. as keys seems inviting, but suffers from not having a canonical order. Let's just impose that order by defining an array of those terms,

my @columns = qw/ Title Author Year Journal
                 # ...
                  /;
for my $record (@results) {
    my $index = 0;
    for (split /\|/, $record) {
        printf "%s: %s$/", $columns[$index], $_ if $_;
        $index++;
    }
}
[download]

That condensation separates data from logic, making the whole easier to maintain. It's not the last word, but a step in the right direction.

Have you looked at any of the CSV modules?

---

---

• Are you posting in the right place? Check out Where do I post X? to know for sure.
• Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:

  <code> <a> <b> <big> <blockquote> <br /> <dd> <dl> <dt> <em> <font> <h1> <h2> <h3> <h4> <h5> <h6> <hr /> <i> <li> <nbsp> <ol> <p> <small> <strike> <strong> <sub> <sup> <table> <td> <th> <tr> <tt> <u> <ul>

• Snippets of code should be wrapped in <code> tags not <pre> tags. In fact, <pre> tags should generally be avoided. If they must be used, extreme care should be taken to ensure that their contents do not have long lines (<70 chars), in order to prevent horizontal scrolling (and possible janitor intervention).
• Want more info? How to link or How to display code and escape characters are good places to start.