Hi dudley.
I felt compelled to offer a little advice. In your open / close functions, I would include some minor modifications in the event of failure (hardware related, etc.).
open(FILE, $filein) or die "Couldn't open file $filein : $!\n";
close (FILE) or die "Couldn't close file : $!\n";
open (NEW, ">$filein") or die "Couldn't open $filein : $!\n";
close (NEW) or die "Couldn't close file: $!\n";
Even though perl will close filehandles for you, I feel it is unwise to not explicitly check for success / failure.
Hope this helps,
-Katie
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|