It's a simple case of re-factoring to strip out this redundancy. Make a simple template function first:
sub getById
{
my ($table, $column, $id) = @_;
my $dbh = sqlConnect();
my $sth = $dbh->prepare("SELECT * FROM $table WHERE $column=?");
$sth->execute($id);
my $result = $sth->fetchrow_hashref();
$sth->finish();
return $result;
}
Now you can call this function with the appropriate parameters, or, try and make these wrapper functions:
sub getCustomerById
{
my ($id) = @_;
return getById("customers", "cust_id", $id);
}
This can be tuned to match any of your various "getXById" functions by simply supplying different parameters.
-
Are you posting in the right place? Check out Where do I post X? to know for sure.
-
Posts may use any of the Perl Monks Approved HTML tags. Currently these include the following:
<code> <a> <b> <big>
<blockquote> <br /> <dd>
<dl> <dt> <em> <font>
<h1> <h2> <h3> <h4>
<h5> <h6> <hr /> <i>
<li> <nbsp> <ol> <p>
<small> <strike> <strong>
<sub> <sup> <table>
<td> <th> <tr> <tt>
<u> <ul>
-
Snippets of code should be wrapped in
<code> tags not
<pre> tags. In fact, <pre>
tags should generally be avoided. If they must
be used, extreme care should be
taken to ensure that their contents do not
have long lines (<70 chars), in order to prevent
horizontal scrolling (and possible janitor
intervention).
-
Want more info? How to link
or How to display code and escape characters
are good places to start.
|